feat(viewer-3d): T/F/R/B/L keyboard shortcuts for ViewCube views#267
Merged
Conversation
Press T/F/R/B/L (any case) to snap to Top/Front/Right/Back/Left — the single-key complement to clicking the ViewCube faces (#258). Reuses the existing applyView/VIEWS path; skips when Alt/Ctrl/Meta is held so browser shortcuts (Ctrl+R reload, Alt+Z zoom-selection) keep working. Verified end-to-end in a headless browser: each key rotates the camera to the matching named view, lowercase and uppercase both fire, and modifier combos are ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds single-key keyboard shortcuts to the viewer-3d ViewCube:
TFRBLKeys are case-insensitive (lower- or upper-case), the single-key complement to clicking the cube faces (#258). They reuse the existing
applyView/VIEWSpath and are skipped whenAlt/Ctrl/Metais held, so browser/app shortcuts (Ctrl+R reload, Alt+Z zoom-selection) keep working.Verification
cargo fmt --check,cargo clippy -D warnings,cargo test(591 + integration).ships_boxselect_and_viewcubefor the new wiring.aware app install+aware app runin a tempAWARE_HOME, loaded the produced HTML in a headless browser, and dispatched keydowns. Each key rotated the camera to the exact named view;Shift+Talso snapped to Top (case-insensitive confirmed);Ctrl+Tcorrectly did not trigger (modifier guard).Review
Codex reviewed (
codex exec review --base main): no findings, no regressions.