Trim trailing frames in offline encode path#5
Open
artuskg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: offline
encode()should trim from tail, not headProblem
In offline
encode():mel[:, 1:]x[remainder:]Both drop leading frames.
Resolution
mel = mel[:, :-1]x = x[:-remainder]Why this helps
This preserves earliest alignment and avoids forward-shifting the encoded sequence relative to streaming/incremental behavior.
Regression test
tests/test_bugfix_encode_trim_optional.py::test_encode_trims_trailing_frames_not_leading_framesHow to run