Flush final pending token in offline generate()#6
Open
artuskg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: flush final pending token in offline
generate()Problem
generate()uses a pending-token decode pattern (yis emitted whilenext_yis being computed). If the loop ends naturally without EOS, the final pending token is dropped.Resolution
After the decode loop, flush the final pending token when it is not EOS.
Why this helps
Prevents deterministic one-token truncation at end-of-audio in non-EOS termination path.
Regression test
tests/test_bugfix_generate_flush_optional.py::test_generate_flushes_last_pending_non_eos_tokenHow to run