feat: Add support for JS and TS interfaces/unions#930
Open
MorFix wants to merge 2 commits intoaws-amplify:mainfrom
Open
feat: Add support for JS and TS interfaces/unions#930MorFix wants to merge 2 commits intoaws-amplify:mainfrom
MorFix wants to merge 2 commits intoaws-amplify:mainfrom
Conversation
MorFix
commented
Feb 6, 2025
MorFix
force-pushed
the
feat/interfaces-unions
branch
5 times, most recently
from
f5fd8b9 to
98536a7
Compare
MorFix
force-pushed
the
feat/interfaces-unions
branch
5 times, most recently
from
b8b87d2 to
fceeb96
Compare
MorFix
force-pushed
the
feat/interfaces-unions
branch
from
fceeb96 to
008df44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
A PR has added support for unions and interfaces.
However, they were still not working for generating models for JS/TS -
index.js,index.d.ts, andschema.jsmetadata file.This PR aims to complete this work and add the necessary support
Codegen Paramaters Changed or Added
N/A
Issue #, if available
N/A
Description of how you validated changes
Updating and adding tests at the moment.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.