feat: Add per-service SDK tag support for bootstrapping new controllers#40
Open
sapphirew wants to merge 5 commits into
Open
feat: Add per-service SDK tag support for bootstrapping new controllers#40sapphirew wants to merge 5 commits into
sapphirew wants to merge 5 commits into
Conversation
knottnt
reviewed
Apr 17, 2026
When bootstrapping a controller for a newly released AWS service whose model only exists under a per-service tag, controller-bootstrap now supports falling back to the per-service git tag. Changes: - Add --aws-service-sdk-version CLI flag - Add ensureSDKRepoPerServiceTag for fetching per-service git tags - Retry getServiceResources with per-service tag on model not found - Populate AWSServiceSDKVersion in template vars
sapphirew
force-pushed
the
feat/per-service-sdk-tags
branch
from
229f4a4 to
7e7a54d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sapphirew The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Use special file name for writeable test that doesn't overlap with test directory added by controller-bootstrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-controllers-k8s/community#2859
Description of changes:
When bootstrapping a controller for a newly released AWS service whose model only exists under a per-service tag, controller-bootstrap now supports falling back to the per-service git tag.
Changes:
--aws-service-sdk-versionCLI flagensureSDKRepoPerServiceTagfor fetching per-service git tagsgetServiceResourceswith per-service tag on model not foundBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.