Remove deprecated aws-go-sdk-v1#167
Remove deprecated aws-go-sdk-v1#167taraspos wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: taraspos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @taraspos. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@taraspos: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues go stale after 180d of inactivity. |
michaelhtm
left a comment
There was a problem hiding this comment.
Thanks for the contribution @taraspos
Great catch on the hooks.go changes. types.go however is generated.
Once that change is removed from the PR, everything else lgtm
|
|
||
| import ( | ||
| ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1" | ||
| "github.com/aws/aws-sdk-go/aws" |
There was a problem hiding this comment.
This file is generated and should not be manually changed. You should make the change here instead: https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/apis/types.go.tpl#L7
Issue #, if available: aws-controllers-k8s/runtime#169
Description of changes:
Go SDK V1 is deprecated now1, this PR removes any direct references to it.
There are still indirect ones, because of dependency on
ec2-controller:$ go mod why -m github.com/aws/aws-sdk-go # github.com/aws/aws-sdk-go github.com/aws-controllers-k8s/eks-controller/cmd/controller github.com/aws-controllers-k8s/ec2-controller/apis/v1alpha1 github.com/aws/aws-sdk-go/awsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Footnotes
https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/ ↩