Skip to content

Remove deprecated aws-go-sdk-v1#167

Open
taraspos wants to merge 2 commits intoaws-controllers-k8s:mainfrom
taraspos:taras/remove-go-sdk-v1
Open

Remove deprecated aws-go-sdk-v1#167
taraspos wants to merge 2 commits intoaws-controllers-k8s:mainfrom
taraspos:taras/remove-go-sdk-v1

Conversation

@taraspos
Copy link

@taraspos taraspos commented Aug 14, 2025

Issue #, if available: aws-controllers-k8s/runtime#169

Description of changes:

Go SDK V1 is deprecated now1, this PR removes any direct references to it.

There are still indirect ones, because of dependency on ec2-controller:

$ go mod why -m github.com/aws/aws-sdk-go
# github.com/aws/aws-sdk-go
github.com/aws-controllers-k8s/eks-controller/cmd/controller
github.com/aws-controllers-k8s/ec2-controller/apis/v1alpha1
github.com/aws/aws-sdk-go/aws

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Footnotes

  1. https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm August 14, 2025 11:58
@ack-prow
Copy link

ack-prow bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taraspos
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 14, 2025

Hi @taraspos. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@taraspos
Copy link
Author

/ok-to-test

@ack-prow
Copy link

ack-prow bot commented Aug 14, 2025

@taraspos: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot
Copy link
Collaborator

ack-bot commented Feb 14, 2026

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2026
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @taraspos
Great catch on the hooks.go changes. types.go however is generated.
Once that change is removed from the PR, everything else lgtm


import (
ackv1alpha1 "github.com/aws-controllers-k8s/runtime/apis/core/v1alpha1"
"github.com/aws/aws-sdk-go/aws"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated and should not be manually changed. You should make the change here instead: https://github.com/aws-controllers-k8s/code-generator/blob/main/templates/apis/types.go.tpl#L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants