fix: set proper desiredSize when increasing minSize#170
fix: set proper desiredSize when increasing minSize#170jose-ledesma wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jose-ledesma The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jose-ledesma. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jose-ledesma Under what circumstances is the external autoscaler applying a desiredSize below the specified minSize for the NodeGroup? Is the external autoscaler also managing minSize and maxSize? |
Description of changes:
When desiredSize is managed by external autoscaling, the ACK EKS controller will not increase minSize if it exceeds desiredSize, instead reporting the following error:
This PR ensures that when minSize exceeds desiredSize, the desiredSize will be automatically adjusted to match minSize, preventing the operation from failing and ensuring successful resource updating.