chore: allow PIA adoption by clusterName, namespace, and ServiceAccount#193
chore: allow PIA adoption by clusterName, namespace, and ServiceAccount#193michaelhtm wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
With these changes, we allow users to use ClusterName, Namespace, and ServiceAccount to adopt a PodIdentityAssociation resource when using `adopt-or-create`
michaelhtm
force-pushed
the
chore/adoptbyclustername
branch
from
f116109 to
98a2228
Compare
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Q: What is the behavior when using the adopt policy?
| // if more than one are returned, we don't want to manage them | ||
| // and treat it as not found | ||
| if len(resp.Associations) != 1 { | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
How about a terminal condition? if we are in adoption mode
There was a problem hiding this comment.
This will just be marked as not found, instead of terminal in sdkFind. This way we can trigger a creation during adopt-or-create
michaelhtm
force-pushed
the
chore/adoptbyclustername
branch
from
f4cdbec to
5160ba8
Compare
|
/test eks-kind-e2e |
michaelhtm
force-pushed
the
chore/adoptbyclustername
branch
from
5160ba8 to
b19ea90
Compare
michaelhtm
force-pushed
the
chore/adoptbyclustername
branch
from
b19ea90 to
a7a3587
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knottnt, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@michaelhtm: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Issue #2684
Description of changes:
With these changes, we allow users to use ClusterName, Namespace, and
ServiceAccount to adopt a PodIdentityAssociation resource when using
adopt-or-createif AssociationID is not provided.Note: this will not work when using
adoptadoption policyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.