Feat/add servicemonitor and prometheusrule#254
Feat/add servicemonitor and prometheusrule#254oded-dd wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
- Add serviceMonitor configuration to values.yaml with interval and scrapeTimeout options - Add prometheusRule configuration with RDSControllerSyncErrors alert (severity: critical) - Create service-monitor.yaml template for Prometheus Operator ServiceMonitor - Create prometheus-rule.yaml template for Prometheus Operator PrometheusRule - Update values.schema.json with schema definitions for new options
The alert expression was referencing job='rds-controller-controller-metrics' but the ServiceMonitor generates job='rds-controller-metrics'. Fixed the mismatch so the alert will correctly match scraped metrics.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oded-dd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ack-prow
bot
added
the
needs-ok-to-test
|
Hi @oded-dd. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hey. Any update on that? |
1 participant
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.