add new resource OptionGroup#257
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kprahulraj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
kprahulraj
force-pushed
the
dboptiongroup
branch
2 times, most recently
from
0d2c010 to
2090dac
Compare
michaelhtm
left a comment
michaelhtm
left a comment
There was a problem hiding this comment.
Thank you @kprahulraj
left a few comments below
apis/v1alpha1/option_group.go
Outdated
| MajorEngineVersion *string `json:"majorEngineVersion"` | ||
| // The description of the option group. | ||
| // +kubebuilder:validation:Required | ||
| OptionGroupDescription *string `json:"optionGroupDescription"` |
There was a problem hiding this comment.
can we rename this to Description?
There was a problem hiding this comment.
@kprahulraj here's a link to the contributor docs section covering renames.
apis/v1alpha1/option_group.go
Outdated
| // | ||
| // Example: myoptiongroup | ||
| // +kubebuilder:validation:Required | ||
| OptionGroupName *string `json:"optionGroupName"` |
There was a problem hiding this comment.
same here..we can rename this to Name
knottnt
left a comment
knottnt
left a comment
There was a problem hiding this comment.
Looking at the API Reference for ModifyOptionGroup I can see that it provides request parameters for configuring Options within the OptionGroup. I think we likely need to update this PR so that users can configure those values.
kprahulraj
force-pushed
the
dboptiongroup
branch
from
2090dac to
61bad00
Compare
|
@kprahulraj: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
Issue #2065
Description of changes:
The Amazon RDS OptionGroup resource represents the RDS Aurora Serverless API's command-line/configuration options for DB clusters.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.