chore: update PerformanceInsights parameters and ignore additional parameters when dbcluster is enabled on dbinstance

[shabbskagalwala]

Fixed terminal errors when PerformanceInsights* parameters cannot be changed when db instance is part of a dbcluster

  conditions:
    - message: >-
        api error InvalidParameterCombination: EnablePerformanceInsights
        conflicts with cluster level parameter.
      status: 'True'
      type: ACK.Terminal
    - lastTransitionTime: '2026-03-12T22:52:45Z'
      message: Resource not synced
      reason: resource is in terminal condition
      status: 'False'
      type: ACK.ResourceSynced
    - lastTransitionTime: '2026-03-12T22:52:45Z'
      message: >-
        api error InvalidParameterCombination: EnablePerformanceInsights
        conflicts with cluster level parameter.

Note to reviewers, the fields are not set on the dbinstance only set on the dbcluster

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ack-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shabbskagalwala
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ack-prow]

Hi @shabbskagalwala. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

/ok-to-test

[shabbskagalwala]

I think the error is different. It could probably be coming from here

rds-controller/pkg/resource/db_instance/hooks.go

Line 139 in d8f8a01

a.ko.Spec.PerformanceInsightsEnabled = aws.Bool(false)

Is there a reason it is explicitly set to false, instead of what is in the latest?

Can this be changed to ?

a.ko.Spec.PerformanceInsightsEnabled = b.ko.Spec.PerformanceInsightsEnabled

[shabbskagalwala]

Adding fields to ignore else the controller is in constant reconcile loop

This db instance is part of a db cluster

{
  "level": "info",
  "ts": "2026-03-13T05:17:50.407Z",
  "logger": "ackrt",
  "msg": "desired resource state has changed",
  "kind": "DBInstance",
  "namespace": "mytest",
  "name": "temp-db-cluster-instance",
  "account": "REDACTED",
  "role": "",
  "region": "us-west-2",
  "is_adopted": true,
  "generation": 5,
  "diff": [
    {
      "Path": {
        "Parts": [
          "Spec",
          "DBName"
        ]
      },
      "A": null,
      "B": "tempdb"
    },
    {
      "Path": {
        "Parts": [
          "Spec",
          "EngineVersion"
        ]
      },
      "A": null,
      "B": "16.8"
    },
    {
      "Path": {
        "Parts": [
          "Spec",
          "MasterUsername"
        ]
      },
      "A": null,
      "B": "superadmin"
    }
  ]
}

[shabbskagalwala]

/retest-required

[ack-prow]

@shabbskagalwala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
rds-verify-attribution	c4e56ca	link	false	/test rds-verify-attribution

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knottnt]

I think the error is different. It could probably be coming from here

rds-controller/pkg/resource/db_instance/hooks.go

Line 139 in d8f8a01

a.ko.Spec.PerformanceInsightsEnabled = aws.Bool(false)

Is there a reason it is explicitly set to false, instead of what is in the latest?

Can this be changed to ?

a.ko.Spec.PerformanceInsightsEnabled = b.ko.Spec.PerformanceInsightsEnabled

@michaelhtm do you recall why this is always set to false?

@shabbskagalwala Regarding the fix. If PerformanceInsightsEnabled should be managed by the DBCluster when the DBInstance's Spec.DBClusterIdentifier is set we could ignore it in the generated delta and add PerformanceInsightsEnabled under this check in custom_pre_compare. newUpdateRequestPayload will then omit setting PerformanceInsightsEnabled in the ModifyDBInstance payload.