Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gpeairs
commented
Mar 25, 2026
Member
Author
|
Holding this until #147 is merged, changing coordinate types is a risk for Booleans on mixed collections without the interface relaxation there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #93. This is a behavior change for Paths where units were implicitly provided as the coordinate type of
p0. For example,Path(0mm, 0mm)is now always the same asPath(). To set the unit type explicitly, usePath(mm, ...).This makes it slightly less convenient to explicitly specify coordinate type units, and may introduce unnecessary conversions where
p0was used to ensure path units agreed with other geometry units. However, it avoids the much more common case of inadvertently specifying units in order to setp0, similarly causing unnecessary conversions down the line.This adds a new constructor for Path (unit + point, e.g.
Path(nm, Point(1,2)mm)) so will require a minor version bump.