Normalize CurvilinearPolygon curve sense in constructor#201
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
laylagi
approved these changes
Apr 14, 2026
Contributor
laylagi
left a comment
laylagi
left a comment
There was a problem hiding this comment.
LGTM - very nice improvement!
gpeairs
force-pushed
the
gp/normalize-csi
branch
from
ee7ccf4 to
efaa934
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CurvilinearPolygon stores a list of curves and their start indices. It allows "reversed-parameterized" curves, designated with a negative start index. It's tricky to make sure this is handled correctly absolutely everywhere. Now that
reverse(::Segment)is defined for all continuous segments, we can just normalize curves in the constructor -- a negative index in the constructor reverses the corresponding segment and is replaced with a positive index.This simplifies some code and fixes some latent bugs, which should make us more confident about using CurvilinearPolygon in other rendering pathways.