ci: add reusable Security Scan workflow (zizmor) and pin actions to SHAs#88
Merged
crowecawcaw merged 2 commits intoJul 7, 2026
Merged
Conversation
Introduces a central, extensible security-scan umbrella workflow that member repos call from a thin stub. zizmor (GitHub Actions static analysis) is the first check; future checks are added here as sibling jobs so repos never need re-editing. zizmor runs advisory by default (continue-on-error) so the existing findings backlog does not turn every PR red; SARIF still uploads to the Security tab. Repos flip fail-on-findings: true once at zero. Actions are SHA-pinned, matching the botocore/s3transfer zizmor setup. Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
- Pin all third-party GitHub Actions (actions/*, aws-actions/*, github/codeql-action) to full commit SHAs with version comments, across every reusable workflow and composite action. Dependabot (already configured) keeps them current. Our own aws-deadline/* reusable workflows keep their @mainline refs on purpose. - Add zizmor.yml: a single central config with an unpinned-uses policy (aws-deadline/* -> ref-pin, everything else -> hash-pin), consumed by reusable_security_scan.yml via --config after checking out this repo. One edit here updates policy for every consuming repo. Eliminates all 77 unpinned-uses findings. Remaining advisory findings (template-injection, excessive-permissions, etc.) are follow-up work. Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
crowecawcaw
force-pushed
the
add-reusable-security-scan
branch
from
July 7, 2026 17:14
0898019 to
7fb4591
Compare
crowecawcaw
changed the title
crowecawcaw
marked this pull request as ready for review
July 7, 2026 17:18
|
|
||
| - name: Download | ||
| uses: actions/download-artifact@v4 | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0 |
There was a problem hiding this comment.
Interesting, should we start pinning the versions for all the repos now ?
karthikbekalp
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
reusable_security_scan.yml— a central, extensible security-scan umbrella workflow that member repos invoke from a thin stub.botocore/s3transferzizmor setup.Rollout posture
zizmor runs advisory by default (
fail-on-findings: false→continue-on-error) so it does not turn every PR red against the current findings backlog. SARIF still uploads to the Security tab, so results stay visible. Each repo flipsfail-on-findings: trueonce its findings reach zero.Why here vs per-repo
Member repos already delegate CI to this org repo's reusable workflows (e.g.
reusable_python_build.yml,reusable_codeql.yml). Putting the logic here keeps the zizmor version/config centrally managed; the companion PR adds the calling stub todeadline-cloud, which is then copied to the rest of the fleet.Companion PR: stub in
aws-deadline/deadline-cloud.Findings preview (offline
zizmorrun, current state)Dominated by
unpinned-uses(tags not SHAs), plus realtemplate-injection(github.base_refintorun:blocks) anddangerous-triggers(workflow_run). Many are auto-fixable in follow-ups.🤖 Draft — not published for review yet.