Path updates and notebook testing#48
Open
jimburtoft wants to merge 22 commits intoaws-neuron:mainfrom
Open
Conversation
- Add nbval-based testing for all notebooks in labs/ - Include timeout configurations per notebook category - Add test runner script with HTML reporting - Add GitHub Actions workflow for CI/CD - Remove parallel execution to avoid Neuron device conflicts - Assume Neuron SDK environment is always available Testing categories: - NxD: 30min timeout for model compilation - FineTuning: 60min timeout for training - vLLM: 30min timeout for server setup - NKI: 15min timeout for kernel development
- Update run_tests.sh to handle directory navigation automatically - Remove parallel execution completely to avoid Neuron device conflicts - Simplify test discovery to work with nbval directly - Verified framework works: discovered 145 test items, executed for 31 minutes - Found 1 real failure in FT-Qwen3-1.7B-chess.ipynb Cell 4 (as expected) The testing framework is now fully functional and ready for use.
- Fixed Cell 4: ~/environment/ml/qwen-chess -> ~/ml/qwen-chess - Fixed Cell 6: /home/ubuntu/neuron-workshops/labs/ml -> ~/ml - Fixed Cell 8: /home/ubuntu/neuron-workshops/labs/ml -> ~/ml These were the remaining hardcoded paths causing the test failure. All paths now consistently use ~/ml/ for model storage.
Added a note about the testing status and order.
Contributor
Author
|
In most cases, the changes are from ~/environment to ~/build-on-trainium-workshop/labs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is to synchronize with changes to the Neuron Workshop to adjust how it is deployed. Previously in the workshop environment, we did a "git clone" but then moved the labs directory into ~/environment. This causes problems in the Chess workshop when we wanted to make changes and have people "git pull" updates after deployment. It has also been a perpetual problem for testing and for using the git repo outside of the workshop environment because of the path differences.
So we will change the workshop to just clone the repo, and then all these paths should work.
I also added the first steps for notebook testing, as well as a few minor changes (outputting the training path in a print statement where it was missing, and including a list of working libraries from the 2.25 training environment in case we need to troubleshoot library shifts again).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.