Open
Conversation
added 30 commits
January 21, 2026 16:45
added 18 commits
January 30, 2026 12:11
…_position_ids to NeuronGemma3ForCausalLM
|
Reviewed and it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contributes the Gemma3 VLM model family (4B, 12B and 27B) to NxDI.
Model Information
Model Name: Gemma3-4b, 12B & 27B
Model Architecture: LLaVA-style VLM with fixed-resolution SigLIP (400M) vision encoder and Transformer decoder text backbone.
Purpose: Image+Text to Text.
Checklist
Please ensure your PR includes the following items. Refer to the contrib/CONTRIBUTING.md for detailed guidelines.
Required Components
Accuracy Test (ex.
test/integration/test_model.py)README.md with the following sections:
Source Code (
src/)Optional Components
test/unit/directoryFolder Structure
Testing
How did you test this change?
Tests included:
vllmfolder)Test Results:
Compatibility
Tested with:
Additional Information
contrib/models/gemma3-vision/src/gemma3_vision/ndxi_patch.pyRelated Issues
N/A
vLLM Integration
For vLLM integration details, see: https://awsdocs-neuron.readthedocs-hosted.com/en/latest/libraries/nxd-inference/developer_guides/onboarding-models.html#nxdi-onboarding-models-vllm
By submitting this PR, I confirm that: