Fixes and improvements to the MySQL database#21
Open
snolan-uturn wants to merge 4 commits intoaws-samples:masterfrom
Open
Fixes and improvements to the MySQL database#21snolan-uturn wants to merge 4 commits intoaws-samples:masterfrom
snolan-uturn wants to merge 4 commits intoaws-samples:masterfrom
Conversation
|
Another change that can be wrapped into this PR is to correct "mysql/sampledb/v1/user/dms_user_privileges.sql" by removing the |
gvk99
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
Syntax error in name_data - missing semi-colon
Duplicate key errors on insert in name_data - this is due to data that varies only by case, resolved by making the name column case sensitive.
Improvement:
Set the character set and collation for the dms_sample database so that it uses utf8 and unicode rather than the latin1 swedish MySQL defaults.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.