docs: fix incorrect label references in Graviton scheduling docs#1810
Open
abhu85 wants to merge 1 commit intoaws-samples:mainfrom
Open
docs: fix incorrect label references in Graviton scheduling docs#1810abhu85 wants to merge 1 commit intoaws-samples:mainfrom
abhu85 wants to merge 1 commit intoaws-samples:mainfrom
Conversation
The documentation incorrectly referenced `tainted=yes` label when the actual nodeSelector uses `kubernetes.io/arch=arm64`. This was confusing because: 1. Line 35 mentioned "tainted=yes" but the manifest uses "kubernetes.io/arch: arm64" 2. Line 88 said the pod was pinned to "tainted=yes" but it was actually pinned to "kubernetes.io/arch=arm64" Updated the explanations to correctly reference the ARM64 architecture label that is actually used in the examples. Fixes aws-samples#1807 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1807
The documentation in the Graviton scheduling section incorrectly referenced a
tainted=yeslabel when the actualnodeSelectorin the manifest useskubernetes.io/arch=arm64.Problem
The documentation contained two incorrect references:
Line 35: "We have pre-configured our tainted managed node group with a label of
tainted=yes..."kubernetes.io/arch: arm64Line 88: "We can see that we have pinned the pod to any node with the
tainted=yeslabel..."kubernetes.io/arch=arm64This was confusing for users following the tutorial because the explanation didn't match the actual code.
Fix
Updated the explanations to correctly reference the
kubernetes.io/arch=arm64label that is actually used in the Kustomize patches and kubectl output.Testing
kubernetes.io/arch: arm64as the nodeSelectorkubernetes.io/arch=arm64Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com