added commands in dockerfile to install git#46
Open
arvy-p wants to merge 1 commit intoaws-samples:masterfrom
Open
added commands in dockerfile to install git#46arvy-p wants to merge 1 commit intoaws-samples:masterfrom
arvy-p wants to merge 1 commit intoaws-samples:masterfrom
Conversation
|
One question regarding this. Should git be installed before the following command? In case there are git commands in requirements.txt |
Contributor
|
Sorry, I'm getting to this late. What is the motivation for having git in the default container? Is it a requirement for a common use case here? At container build time or container run time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I have updated Dockerfile with RUN commands to have git installed
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.