fix(agent-gateway): add /mcp to ingress and manage ingress via chart#7
Open
elamaran11 wants to merge 1 commit into
Open
fix(agent-gateway): add /mcp to ingress and manage ingress via chart#7elamaran11 wants to merge 1 commit into
elamaran11 wants to merge 1 commit into
Conversation
The agentgateway ALB ingress was created outside the chart (no ingress template existed), so adding /mcp to it was reverted by ArgoCD on every sync. This commit: 1. Adds ingress.yaml template to the agent-gateway chart so the ingress is fully managed by GitOps. Includes both /sse and /mcp paths. 2. Adds ingress.enabled/className/host values to values.yaml. 3. Enables the ingress in addons.yaml with host derived from the cluster secret's ingress_domain_name annotation — same pattern used by all other platform ingresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6. The agentgateway ALB ingress was created outside the chart (no ingress template existed), so adding
/mcpto it was reverted by ArgoCD on every sync.Changes
1. Add
ingress.yamltemplate to agent-gateway chartThe ingress is now fully managed by GitOps. Includes both
/sseand/mcppaths so AgentGateway can receive both SSE and StreamableHTTP MCP requests.2. Add ingress values to
values.yamlNew
ingress.enabled/className/hostvalues with safe defaults (enabled: false).3. Enable ingress in
addons.yamlSets
ingress.enabled: trueand deriveshostfrom the cluster secret'singress_domain_nameannotation — same pattern used by all other platform ingresses (keycloak, argo-workflows, etc.).Result
After merge + Argo refresh:
POST https://<domain>/mcpwith JWT → routes to AgentGateway → StreamableHTTP to MCP proxy → returns tools listGET https://<domain>/ssewith JWT → SSE stream (existing behavior unchanged)/mcppath on sync