fix(composer): define module logger — NameError on group MCP stop failure#197
Merged
Conversation
…lure The finally block at run_group exit calls logger.warning() when the per-group MCPClient fails to stop, but composer.py never defined `logger` — the warning path itself raised NameError instead of logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent/modes/separated/composer.pycallslogger.warning()in therun_groupfinally block (per-group MCP stop failure path) but never definedlogger— the warning itself raisedNameError.logging.getLogger("sdpm.agent")module logger (same convention as factory.py / session.py / streaming.py).Background
Found while investigating roadmap 3-4 (compose checkpoint resume). 3-4 itself was closed as won't-do: the deck workspace already persists
slides/*.jsonon write, so the workspace itself is the checkpoint; group failures are covered by the #193 structured-error retry flow. Rationale recorded in the roadmap spec notes (local ledger).Test
make lint/make test— 251 passed, 1 skipped