build: Allow any v4 libtss#20
Open
agraf wants to merge 1 commit into
Open
Conversation
I tried to compile with the current git version of libtss2 (4.1.0-foo) and was greeted with a build error. Major versions should maintain API compatibility, so I don't expect any issue compiling with any version from the 4 major version series. Adjust the semver accordingly. To make compilation successful with git checkouts, also strip the prerelease info when comparing versions. Without that stripping, compilation still failed. Signed-off-by: Alexander Graf <graf@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to compile with the current git version of libtss2 (4.1.0-foo) and was greeted with a build error. Major versions should maintain API compatibility, so I don't expect any issue compiling with any version from the 4 major version series. Adjust the semver accordingly.
To make compilation successful with git checkouts, also strip the prerelease info when comparing versions. Without that stripping, compilation still failed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.