feat: add telemetry preference controls and preinstall notice#418
Draft
jesseturner21 wants to merge 1 commit intoaws:mainfrom
Draft
feat: add telemetry preference controls and preinstall notice#418jesseturner21 wants to merge 1 commit intoaws:mainfrom
jesseturner21 wants to merge 1 commit intoaws:mainfrom
Conversation
jesseturner21
requested a deployment
to
e2e-testing
GitHub Actions
Waiting
github-actions
bot
added
size/l
jesseturner21
force-pushed
the
feat/telemetry-controls
branch
from
5184052 to
4c2421f
Compare
Add user-facing telemetry controls (opt-out command, env var support, config file, preinstall notice) without collecting any data. This establishes the user-facing messaging before launch. - Add `agentcore telemetry` command with enable/disable/status subcommands - Add telemetry notice as a warning in preinstall script (shown on install/upgrade) - Support AGENTCORE_TELEMETRY_DISABLED and DO_NOT_TRACK env vars - Add global config module (~/.agentcore/config.json) for persisting preferences - Refactor update-notifier to reuse shared GLOBAL_CONFIG_DIR constant - Add unit tests for global config, preference resolution, and command actions
jesseturner21
force-pushed
the
feat/telemetry-controls
branch
from
4c2421f to
402275b
Compare
jesseturner21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI #418
Telemetry Preference Controls
The AgentCore CLI uses the CDK for resource deployment and management tasks, enabling seamless transition to IaC-based management of agents. As part of that integration, the CLI inherits CDK CLI as a dependency, which includes CDK's telemetry behavior.
This PR introduces two things: opt-out controls for telemetry, and a telemetry spec that defines what will be collected in a future release.
Opt-out controls
This PR delivers preference controls only. No data is collected until a future release. Every existing user and CI pipeline will have the opt-out mechanism available before any telemetry is ever sent.
Controls included in this PR:
Preferences are stored in ~/.agentcore/config.json and resolved in this order: env vars > config file > default (enabled).
Telemetry spec
When data collection ships in a future release, the AgentCore CLI will collect only aggregated, anonymous usage analytics. The spec explicitly excludes account IDs, region, resource names, error payloads, and any data that could be associated with a specific user, account, or organization. A local inspection capability will also be included so users can verify exactly what is being sent.
Message at npm install or update time
Description
Add user-facing telemetry preference controls (This PR is controls only, no data collection) to the AgentCore CLI. This establishes the opt-out mechanism and install-time notice so users are informed and in control before telemetry collection is enabled in a future release of the CLI.
What's included:
Our plans have been informed by the following CDK discussions: