Skip to content

Bump prometheus v0.312.0, prometheus-operator v0.92.1 to remove docker dependency #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathalapooja wants to merge 1 commit into from
Closed

Bump prometheus v0.312.0, prometheus-operator v0.92.1 to remove docker dependency #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cmd/amazon-cloudwatch-agent-target-allocator/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,13 @@ func main() {
srv := server.NewServer(log, allocator, cfg.ListenAddr, httpOptions...)

discoveryCtx, discoveryCancel := context.WithCancel(ctx)
discoveryManager = discovery.NewManager(discoveryCtx, nil, prometheus.NewRegistry(), nil)
discoveryRegistry := prometheus.NewRegistry()
sdMetrics, err := discovery.CreateAndRegisterSDMetrics(discoveryRegistry)
if err != nil {
setupLog.Error(err, "Unable to create service discovery metrics")
os.Exit(1)
}
discoveryManager = discovery.NewManager(discoveryCtx, nil, discoveryRegistry, sdMetrics)

targetDiscoverer = target.NewDiscoverer(log, discoveryManager, allocatorPrehook, srv)
collectorWatcher, collectorWatcherErr := collector.NewClient(log, cfg.ClusterConfig)
Expand Down
15 changes: 12 additions & 3 deletions cmd/amazon-cloudwatch-agent-target-allocator/target/discovery_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,10 @@ func TestDiscovery_ScrapeConfigHashing(t *testing.T) {

scu := &mockScrapeConfigUpdater{}
ctx := context.Background()
d := discovery.NewManager(ctx, slog.Default(), prometheus.NewRegistry(), nil)
reg := prometheus.NewRegistry()
sdMetrics, err := discovery.CreateAndRegisterSDMetrics(reg)
require.NoError(t, err)
d := discovery.NewManager(ctx, slog.Default(), reg, sdMetrics)
manager := NewDiscoverer(ctrl.Log.WithName("test"), d, nil, scu)

for _, tc := range tests {
Expand Down Expand Up @@ -330,7 +333,10 @@ func TestDiscovery_ScrapeConfigHashing(t *testing.T) {
func TestDiscovery_NoConfig(t *testing.T) {
scu := &mockScrapeConfigUpdater{mockCfg: map[string]*promconfig.ScrapeConfig{}}
ctx, cancelFunc := context.WithCancel(context.Background())
d := discovery.NewManager(ctx, slog.Default(), prometheus.NewRegistry(), nil)
reg := prometheus.NewRegistry()
sdMetrics, err := discovery.CreateAndRegisterSDMetrics(reg)
require.NoError(t, err)
d := discovery.NewManager(ctx, slog.Default(), reg, sdMetrics)
manager := NewDiscoverer(ctrl.Log.WithName("test"), d, nil, scu)
defer close(manager.close)
defer cancelFunc()
Expand Down Expand Up @@ -377,7 +383,10 @@ func BenchmarkApplyScrapeConfig(b *testing.B) {

scu := &mockScrapeConfigUpdater{}
ctx := context.Background()
d := discovery.NewManager(ctx, slog.Default(), prometheus.NewRegistry(), nil)
reg := prometheus.NewRegistry()
sdMetrics, err := discovery.CreateAndRegisterSDMetrics(reg)
require.NoError(b, err)
d := discovery.NewManager(ctx, slog.Default(), reg, sdMetrics)
manager := NewDiscoverer(ctrl.Log.WithName("test"), d, nil, scu)

b.ResetTimer()
Expand Down
Loading
Loading