Skip to content

Add root-level cluster_name and standardize collection_interval for OpenTelemetry features#2189

Open
Paamicky wants to merge 6 commits into
mainfrom
zeus-V2-json-configs
Open

Add root-level cluster_name and standardize collection_interval for OpenTelemetry features#2189
Paamicky wants to merge 6 commits into
mainfrom
zeus-V2-json-configs

Conversation

@Paamicky

@Paamicky Paamicky commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description of the issue

The OpenTelemetry config section had two inconsistencies: cluster_name was required per-component, forcing customers to repeat the same cluster value for every feature, and the collection interval field name differed across features (metrics_collection_interval vs collection_interval). This has been updated to use the newer version collection_interval

Description of changes

  • Root-level cluster_name: Moved to opentelemetry.cluster_name. A single value now applies to all features (Container Insights, Prometheus, Host Metrics, OTLP). Container Insights and Prometheus require it; Host Metrics and OTLP apply it when present.
  • Standardized collection_interval: All OpenTelemetry features now use collection_interval with a 30-second default. Host Metrics renamed from metrics_collection_interval. Database Insights retains its own hardcoded intervals.
  • Centralized validation: ClusterNameRegex moved to the common package. GetOtelClusterName and GetCollectionInterval added as shared helpers.
  • Schema updated: schema.json reflects the new root-level cluster_name field and standardized collection_interval across features.

Tests

  • Unit tests for GetOtelClusterName verifies root-level reads, env var is not used as fallback, empty config returns empty
  • Unit tests for GetCollectionInterval verifies feature-level override, 30s default, zero/negative values ignored
  • Updated golden file tests and confirm set_cluster_name processor appears in all applicable pipelines
  • All existing translator tests pass

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Paamicky Paamicky added the ready for testing Indicates this PR is ready for integration tests to run label Jul 9, 2026
@Paamicky Paamicky marked this pull request as ready for review July 9, 2026 16:17
@Paamicky Paamicky requested a review from a team as a code owner July 9, 2026 16:17
@Paamicky Paamicky changed the title Add root-level cluster_name and standardize collection_interval for … Add root-level cluster_name and standardize collection_interval for OpenTelemetry features Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for testing Indicates this PR is ready for integration tests to run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant