fix: restrict aws.dev.amazonqLsp to machine scope#120
Merged
Conversation
Declare the aws.dev.amazonqLsp developer setting in the extension manifest with "scope": "machine" so it is only configurable at the user/machine level and not via workspace settings. Adds a test asserting the scope declaration.
aseemxs
changed the title
kmmcclai
reviewed
Jun 17, 2026
| "type": "object", | ||
| "scope": "machine", | ||
| "default": {}, | ||
| "markdownDescription": "Developer use only" |
There was a problem hiding this comment.
"Developer user only" should probably be defined as an NLS (localization) placeholder (similar to other markdownDescriptions in the file, e.g.: %AWS.configuration.description.amazonq.proxy.developerUserOnly%
With the actual text stored in packages/core/package.nls.json
kmmcclai
approved these changes
Jun 17, 2026
kmmcclai
left a comment
kmmcclai
left a comment
There was a problem hiding this comment.
Minor nit about localization, otherwise LGTM.
Use an NLS placeholder for the aws.dev.amazonqLsp markdownDescription and store the text in package.nls.json, consistent with the other configuration descriptions.
kmmcclai
approved these changes
Jun 17, 2026
ashishrp-aws
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
aws.dev.amazonqLspdeveloper setting is not declared in the extension manifest, so it has no scope restriction and can be set from workspace settings. Developer overrides like this should only be configurable at the user/machine level.Change
aws.dev.amazonqLspincontributes.configurationwith"scope": "machine", so it is only settable in user/machine settings and not by a workspace's.vscode/settings.json.machinescope.Testing