fix: ignore aws.dev.* setting overrides in release builds#122
Merged
Conversation
Gate DevSettings.get() so that developer-only "aws.dev.*" overrides are ignored in release builds unless "aws.dev.forceDevMode" is explicitly set. These settings are intended for local development and should be inert in the shipped extension. Adds unit tests for the release-build behavior.
aseemxs
changed the title
kmmcclai
approved these changes
Jun 17, 2026
ashishrp-aws
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
aws.dev.*developer settings are read byDevSettings.get()regardless of build type. These settings are intended only for local development, but they are currently honored even in shipped/release builds.Change
DevSettings.get()so thataws.dev.*overrides are ignored in release builds, unless the developer has explicitly opted in viaaws.dev.forceDevMode.forceDevModeworkflow for local development.forceDevModeescape hatch.Testing
settings.test.tsfor the release-build gate.DevSettingtests remain valid (isReleaseVersion()is false in the test environment, so the gate is inert there).