deps: fix webpack SSRF alerts #68/#69 (pin enhanced-resolve)#138
Merged
laileni-aws merged 1 commit intoJul 15, 2026
Merged
Conversation
Problem: Bumping webpack to the patched ^5.104.1 (fixes GHSA build-time SSRF alerts aws#68/aws#69) pulls enhanced-resolve 5.24.x, whose stricter exports resolution breaks the web bundle (aws-core-vscode/shared no longer resolves from packages/core/dist), failing package VSIX and test Web. Solution: Bump webpack to ^5.104.1 and override enhanced-resolve to 5.17.1 (the version main uses and known to resolve core's exports). npm overrides bypass webpack's declared enhanced-resolve range, so the SSRF fix lands while the lenient, working resolver is retained. Brings total resolved to 154 of 160 Dependabot alerts. Remaining 6 alerts are unpatched upstream (aws-sdk v2, elliptic), require major upstream package upgrades (@opentelemetry/core via @aws/language-server-runtimes, @smithy/config-resolver via old @aws-sdk clients), or are stale/false-positive (@protobufjs/utf8).
laileni-aws
force-pushed
the
fix/dependabot-security-alerts-part3
branch
from
July 14, 2026 20:36
95c1dd6 to
f3dab58
Compare
laileni-aws
marked this pull request as ready for review
July 14, 2026 20:40
kmmcclai
approved these changes
Jul 14, 2026
laileni-aws
enabled auto-merge (squash)
July 15, 2026 00:02
chungjac
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
webpackSSRF alerts #68 / #69 were deferred from #136 / #137 becausebumping
webpackto the patched^5.104.1pullsenhanced-resolve5.24.x,whose stricter
exports-field resolution breaks the web bundle(
aws-core-vscode/sharedno longer resolves frompackages/core/dist), failingthe
package VSIXandtest Webjobs.Solution
Bump
webpackto^5.104.1(resolves #68/#69) and overrideenhanced-resolveto 5.17.1 — the exact resolvermainuses, which isknown to resolve core's
exportscorrectly. npmoverridesbypass webpack'sdeclared
enhanced-resolverange, so the SSRF fix lands while the working,lenient resolver is retained.
Change
webpack^5.95.0→^5.104.1enhanced-resolve(override)5.17.1exportsresolution workingStill open after this PR (6 — none safely fixable here)
aws-sdk#42, #44elliptic#43<=6.6.1, none released)@opentelemetry/core#225@aws/language-server-runtimes; needs that upgraded@smithy/config-resolver#41@aws-sdkv3 clients; needs those upgraded@protobufjs/utf8#200protobufjs@7.6.3Verification
webpack5.108.4 withenhanced-resolve5.17.1(override),
webpack@>=5.104.1clears refactor: removing redundant code from amazon q repo #68/Amazon Q chat window is not showing #69.(
package VSIX,test Web) stay green with the pinned resolver.feature/xbranches will not be squash-merged at release time.