fix: scope inline chat accept/reject lenses to the task document#142
Draft
laileni-aws wants to merge 1 commit into
Draft
fix: scope inline chat accept/reject lenses to the task document#142laileni-aws wants to merge 1 commit into
laileni-aws wants to merge 1 commit into
Conversation
The inline chat CodeLens provider is registered for all documents and returned its lenses regardless of which document was being queried. When a user triggered inline chat and then switched to another file before accepting or rejecting, the Accept/Reject (and generating) lenses appeared in that unrelated file. Track the document that owns the active inline task and only return the lenses when the queried document matches it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using inline chat, if the user triggers a suggestion and then switches to another file without accepting or rejecting it, the
Accept/Rejectcode lenses (and the "Amazon Q is generating..." lens) appear in that unrelated file.Root cause
CodelensProvider(inpackages/amazonq/src/inlineChat/codeLenses/codeLenseProvider.ts) is registered for all documents:and
provideCodeLenses(_document, _token)returnedthis.codeLenseswhile ignoring the_documentargument. So the lenses built for the active inline task were returned for every document VS Code queried — including whatever file the user switched to.Fix
Track the document that owns the active inline task (
task.document.uri) and only return the lenses when the queried document matches:The owning document URI is set in
updateLensesand cleared when the task completes.Testing
packages/amazonq/test/unit/inlineChat/codeLenseProvider.test.ts:Notes