deps: bump adm-zip to 0.6.0 to patch high-severity advisory#147
Merged
Conversation
laileni-aws
force-pushed
the
feature/gh-security-fixes
branch
from
July 20, 2026 21:48
b80697f to
2cd73d0
Compare
laileni-aws
changed the title
Problem: adm-zip ^0.5.10 (in packages/core) has an open high-severity Dependabot advisory (alerts #249, #250). The root build scripts (scripts/lspArtifact.ts) import adm-zip but only relied on it being hoisted from packages/core. Solution: - Bump adm-zip to ^0.6.0 in packages/core. - Declare adm-zip ^0.6.0 (+ @types/adm-zip) in the root package.json, since the root build scripts import it directly — this keeps it resolvable at the root regardless of workspace hoisting (fixes "Cannot find module 'adm-zip'" during packaging). - Regenerate the lockfile. Other open alerts (uuid, @opentelemetry/core, @smithy/config-resolver — multiple coexisting versions; aws-sdk, elliptic — no patch) are deferred for scoped human review.
laileni-aws
force-pushed
the
feature/gh-security-fixes
branch
from
July 20, 2026 21:57
2cd73d0 to
7f15e86
Compare
laileni-aws
marked this pull request as ready for review
July 20, 2026 22:12
chungjac
approved these changes
Jul 20, 2026
laileni-aws
enabled auto-merge (squash)
July 21, 2026 21:28
ashishrp-aws
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-prepared draft security fix from the
q-plugin-gh-security-monitormonitor.This PR bumps a single high-severity dependency to its patched version; other open
alerts are deferred (see below) because they are not safe to auto-fix.
Fixed
adm-zip^0.5.10→^0.6.0(packages/core/package.json) — patches thehigh-severity Dependabot alert (#249 root lock, #250
packages/core).Deferred for human review (NOT in this PR)
uuid,@opentelemetry/core,@smithy/config-resolver: multiple major versionscoexist in
package-lock.json(e.g.@smithy/config-resolverhas 14 tree entries).A blanket
overridespin would risk breaking the AWS SDK / OpenTelemetry graph, sothese need scoped, per-parent bumps by a maintainer.
aws-sdk(×2),elliptic: no patched version available yet — nothing to bump.Not addressed here (report-only)
js/disabling-certificate-validation(
packages/core/src/shared/utilities/proxyUtil.ts) — requires a human-authored sourcefix; flagged for triage, not auto-fixed.
Verification
npm install --package-lock-onlyregenerated the lock; diff is limited toadm-zip.Draft — opened for review by q-plugin-gh-security-monitor. Please review, build/test, and merge.