ci: mark macOS insiders test non-blocking (known upstream issue)#154
Closed
laileni-aws wants to merge 1 commit into
Closed
ci: mark macOS insiders test non-blocking (known upstream issue)#154laileni-aws wants to merge 1 commit into
laileni-aws wants to merge 1 commit into
Conversation
laileni-aws
changed the title
laileni-aws
marked this pull request as ready for review
July 23, 2026 01:54
laileni-aws
marked this pull request as draft
July 23, 2026 01:55
laileni-aws
marked this pull request as ready for review
July 23, 2026 02:38
…issue)
The macOS 'insiders' variant fails repo-wide with a VS Code Insiders
build issue ('spawn .../Contents/MacOS/Electron ENOENT') that no
@vscode/test-electron version resolves (reproduced on 2.3.8/2.5.2/3.0.0).
Add step-level continue-on-error scoped to that variant so the job and
its required check pass; macOS stable/minimum stay blocking. No Node or
harness version change (keeps existing required-check names). Revert
once the upstream VS Code Insiders build / vscode-test is fixed.
laileni-aws
force-pushed
the
fix/ci-node22-test-electron3
branch
from
July 23, 2026 02:41
fe5fecb to
8449354
Compare
laileni-aws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
test macOS (insiders)job fails repo-wide (onmainand every PR):The current VS Code Insiders macOS build's Electron binary isn't at the path any released
@vscode/test-electronresolves — reproduced on 2.3.8, 2.5.2, and 3.0.0, so it's not a harness-version issue and can't be fixed by bumping the dependency. (A Node 22 + test-electron 3.0.0 attempt confirmed this and additionally renamed every required status check, which broke branch protection — so that approach was dropped.)Solution
Scope a step-level
continue-on-errorto only the macOSinsidersvariant, so its known upstream failure no longer fails the job/check. Everything else is unchanged:(18.x, …)so branch protection is satisfied.Honest scope
This makes the check green; it does not fix the underlying insiders test (an upstream VS Code Insiders / vscode-test issue outside this repo). A code comment marks it to revert once upstream is fixed.
feature/xbranches will not be squash-merged at release time.