You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wrapper caches the connection creation function, causing pooled connections to always be populated with the initial connection properties.
This impacts long running applications using temporary credentials, as new pooled connections created with stale credentials will fail. This PR updates the pooled connection provider's connect method to use the latest DSN when creating connections.
While this PR addresses the stale credentials, could a more flexible architectural approach be adopted to solve such issues, such as a driver chain like: AWS Wrapper Driver -> Credentials Wrapper Driver -> Physical MySQL Driver?
Specifically, could the UnderlyingDriver in the mysql-driver implementation be made injectable or configurable? This would allow users to provide a Credentials Wrapper Driver to implement specialized credential logic requirements. Currently, because the physical driver is hardcoded, users who need custom logic must maintain their own full wrapper implementations, which increases maintenance overhead whenever the internal interfaces of the wrapper evolve.
What do you think about this direction for future extensibility?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrapper caches the connection creation function, causing pooled connections to always be populated with the initial connection properties.
This impacts long running applications using temporary credentials, as new pooled connections created with stale credentials will fail. This PR updates the pooled connection provider's connect method to use the latest DSN when creating connections.
Testing
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.