chore: directly retrieve connections from ICP when using the ICP#285
Open
chore: directly retrieve connections from ICP when using the ICP#285
Conversation
sergiyvamz
reviewed
Nov 4, 2024
| logger.debug(Messages.get("ReadWriteSplittingPlugin.setWriterClient", writerHost.url)); | ||
| // Verify clients from internal pools. | ||
| if (!(await this.isTargetClientUsable(targetClient))) { | ||
| logger.debug(Messages.get("ReadWriteSplittingPlugin.failedToConnectToWriter", writerHost.url)); |
Contributor
There was a problem hiding this comment.
So targetClient isn't good. Should we get a new one?
sergiyvamz
reviewed
Nov 4, 2024
| logger.debug(Messages.get("ReadWriteSplittingPlugin.setReaderClient", readerHost.url)); | ||
| // Verify clients from internal pools. | ||
| if (!(await this.isTargetClientUsable(targetClient))) { | ||
| logger.debug(Messages.get("ReadWriteSplittingPlugin.failedToConnectToReader", readerHost.url)); |
Contributor
There was a problem hiding this comment.
So targetClient isn't good. Should we get a new one?
Contributor
Author
There was a problem hiding this comment.
I think we should log and throw here instead.
joyc-bq
approved these changes
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.