fix: move test_weight_random_host_selector.py to unit test folder #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faviansamatha
force-pushed
the
fix/testfixes
branch
from
0639abb to
148f30f
Compare
sophia-bq
approved these changes
Jan 19, 2026
sophia-bq
reviewed
Jan 19, 2026
| @enable_on_features([TestEnvironmentFeatures.FAILOVER_SUPPORTED]) | ||
| def test_pooled_connection__cluster_url_failover( | ||
| self, test_driver: TestDriver, rds_utils, conn_utils, failover_props | ||
| self, test_driver: TestDriver, rds_utils, conn_utils, failover_props, cleanup_connection_provider |
Contributor
There was a problem hiding this comment.
just wondering on all the cleanup for these tests - what is happening with clear caches and is it worthwhile to combine it with the setup method? How much is needed to be cleaned up given the same things are called in conftest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.