This repository was archived by the owner on Jun 10, 2026. It is now read-only.
fix(testing-sdk): checkpoint validation parent & duplicate IDs#75
Merged
Conversation
yaythomas
force-pushed
the
checkpoint-batching
branch
from
a0dfd8a to
6007120
Compare
yaythomas
changed the title
yaythomas
force-pushed
the
checkpoint-batching
branch
from
6007120 to
ac98b17
Compare
bchampp
reviewed
Oct 28, 2025
bchampp
reviewed
Oct 28, 2025
bchampp
reviewed
Oct 28, 2025
The SDK now uses background thread batching for checkpoints, which can send multiple updates for the same operation in a single batch (e.g., START followed by SUCCEED for fast-completing operations). Updated the checkpoint validator to allow this valid behavior. Changes: - Allow duplicate operation IDs in checkpoint batches for STEP/CONTEXT operations when first action is START and subsequent is non-START - Reject duplicate IDs for other operation types (WAIT, CALLBACK, etc.) - Add 11 new tests covering all duplicate/inconsistency scenarios - Add pragma comments to Protocol method stubs in serialization.py
yaythomas
force-pushed
the
checkpoint-batching
branch
from
ac98b17 to
ccc4849
Compare
bchampp
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK now uses background thread batching for checkpoints, which can send multiple updates for the same operation in a single batch (e.g., START followed by SUCCEED for fast-completing operations). Updated the checkpoint validator to allow this valid behavior.
Ref #52
Changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.