Remove RequiresPreviewFeatures attribute for Lambda Response Streaming#2467
Open
normj wants to merge 3 commits into
Open
Remove RequiresPreviewFeatures attribute for Lambda Response Streaming#2467normj wants to merge 3 commits into
normj wants to merge 3 commits into
Conversation
…g now that the changes have been deployed to the managed runtime.
philasmar
approved these changes
Jul 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes RequiresPreviewFeatures gating from Lambda response streaming and related APIs now that the capability is considered GA, and updates affected unit tests to assert the correct HTTP API v2 prelude shape.
Changes:
- Removed
RequiresPreviewFeaturesattributes (and related preview-message constants) from response streaming and structured logging surfaces. - Updated response streaming tests to validate HTTP API v2 prelude behavior using single-value
Headers(joining multi-values with", "), and removed preview-attribute assertions. - Added an
.autoverchange entry to publish the GA/preview-attribute removal in changelogs.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| Libraries/test/Amazon.Lambda.AspNetCoreServer.Test/StreamingResponseBodyFeatureTests.cs | Drops preview attribute usage in tests for streaming response body feature. |
| Libraries/test/Amazon.Lambda.AspNetCoreServer.Test/StreamingFunctionHandlerAsyncTests.cs | Removes preview attributes and the test that asserted preview-only gating. |
| Libraries/test/Amazon.Lambda.AspNetCoreServer.Test/ResponseStreamingPropertyTests.cs | Updates assertions to match HTTP API v2 prelude Headers behavior. |
| Libraries/test/Amazon.Lambda.AspNetCoreServer.Test/BuildStreamingPreludeTests.cs | Updates prelude tests to validate Headers (v2) instead of MultiValueHeaders. |
| Libraries/test/Amazon.Lambda.AspNetCoreServer.Hosting.Tests/ResponseStreamingPropertyTests.cs | Removes preview attribute from hosting-level response streaming property tests. |
| Libraries/test/Amazon.Lambda.AspNetCoreServer.Hosting.Tests/ResponseStreamingHostingTests.cs | Removes preview attribute from hosting integration tests. |
| Libraries/src/Amazon.Lambda.Core/ResponseStreaming/LambdaResponseStreamFactory.cs | Removes preview gating from response streaming factory API and message constant. |
| Libraries/src/Amazon.Lambda.Core/ResponseStreaming/LambdaResponseStream.cs | Removes preview gating from the streaming Stream implementation. |
| Libraries/src/Amazon.Lambda.Core/ResponseStreaming/HttpResponseStreamPrelude.cs | Removes preview gating from the HTTP prelude type. |
| Libraries/src/Amazon.Lambda.Core/LambdaLogger.cs | Removes preview gating from ConfigureStructuredLogging. |
| Libraries/src/Amazon.Lambda.AspNetCoreServer/Internal/StreamingResponseBodyFeature.cs | Removes preview gating from ASP.NET Core streaming response feature implementation. |
| Libraries/src/Amazon.Lambda.AspNetCoreServer/ApplicationLoadBalancerFunction.cs | Removes preview attribute from streaming prelude builder override point. |
| Libraries/src/Amazon.Lambda.AspNetCoreServer/APIGatewayProxyFunction.cs | Removes preview attribute from streaming prelude builder (REST API variant). |
| Libraries/src/Amazon.Lambda.AspNetCoreServer/APIGatewayHttpApiV2ProxyFunction.cs | Removes preview attribute from streaming prelude builder (HTTP API v2 variant). |
| Libraries/src/Amazon.Lambda.AspNetCoreServer/AbstractAspNetCoreFunction.cs | Removes preview-gating attributes and the preview message constant from base surface. |
| Libraries/src/Amazon.Lambda.AspNetCoreServer.Hosting/HostingOptions.cs | Removes preview attribute from hosting option EnableResponseStreaming. |
| .autover/changes/9e75413c-9cb6-4521-aaca-09b557fff2b3.json | Adds changelog messages for GA promotion / preview-attribute removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
the changes seem fine - i think you still need to update |
| }, | ||
| { | ||
| "Name": "Amazon.Lambda.Annotations", | ||
| "Type": "Minor", |
Contributor
There was a problem hiding this comment.
i dont see any annotation changes in this pr but i see it in the changefile?
| "Name": "Amazon.Lambda.PowerShellHost", | ||
| "Type": "Minor", | ||
| "ChangelogMessages": [ | ||
| "Updated Amazon.Lambda.Core dependency to include Lambda Response Streaming support." |
Contributor
There was a problem hiding this comment.
are you missing some csproj updates or somthing somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1635
Description of changes:
The Lambda response streaming changes have been deployed to the .NET managed runtimes so the
RequiresPreviewFeaturesattribute can be removed and the feature can be considered GA.Some tests need some clean up because they were making incorrection assertions. The source was correct so no changes in what has been shipped. I'm tracking down separately how the tests were able to successfully merged into
devwhile failing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.