chore: remove deprecated AWS_LWA_READINESS_CHECK_MIN_UNHEALTHY_STATUS#663
Closed
chore: remove deprecated AWS_LWA_READINESS_CHECK_MIN_UNHEALTHY_STATUS#663
Conversation
Remove the deprecated AWS_LWA_READINESS_CHECK_MIN_UNHEALTHY_STATUS environment variable and all associated code. Users should use AWS_LWA_READINESS_CHECK_HEALTHY_STATUS instead. Changes: - Remove ENV_READINESS_CHECK_MIN_UNHEALTHY_STATUS constant and fallback logic - Remove readiness_check_min_unhealthy_status field from AdapterOptions - Remove deprecation notices from README and environment-variables docs - Clean up #[allow(deprecated)] annotations and commented-out code in tests
📊 Benchmark ComparisonBenchmark Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the deprecated
AWS_LWA_READINESS_CHECK_MIN_UNHEALTHY_STATUSenvironment variable and all associated code. Users should useAWS_LWA_READINESS_CHECK_HEALTHY_STATUSinstead.Changes
ENV_READINESS_CHECK_MIN_UNHEALTHY_STATUSconstant and fallback logic insrc/lib.rsreadiness_check_min_unhealthy_statusfield fromAdapterOptions#[allow(deprecated)]annotations and commented-out code in testsTesting
cargo build— compiles cleanlycargo nextest run— all 53 tests passcargo clippy --all-targets— no warnings