Conversation
BREAKING CHANGE: Remove readiness_check_min_unhealthy_status field and AWS_LWA_READINESS_CHECK_MIN_UNHEALTHY_STATUS env var. Use readiness_check_healthy_status / AWS_LWA_READINESS_CHECK_HEALTHY_STATUS instead. - Remove deprecated readiness_check_min_unhealthy_status from AdapterOptions - Remove ENV_READINESS_CHECK_MIN_UNHEALTHY_STATUS constant and fallback logic - Remove #[allow(deprecated)] annotations no longer needed - Add migration guide section to README (0.x to 1.0) - Add SECURITY.md with vulnerability reporting policy - Update README security section to reference SECURITY.md - Add CHANGELOG entries for v0.8.0 through v1.0.0 - Fix outdated repo URL in docs/development.md
📊 Benchmark ComparisonBenchmark Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare the project for 1.0.0 GA release with breaking changes, documentation, and cleanup.
Breaking Changes
readiness_check_min_unhealthy_statusfield fromAdapterOptionsAWS_LWA_READINESS_CHECK_MIN_UNHEALTHY_STATUSenvironment variablereadiness_check_healthy_status/AWS_LWA_READINESS_CHECK_HEALTHY_STATUSinstead (supports comma-separated codes and ranges, e.g.200-399,404)Changes
Code (
src/lib.rs,tests/integ_tests/main.rs)readiness_check_min_unhealthy_statusfield, env var constant, and fallback logic#[allow(deprecated)]annotations that were only needed for the removed fieldDocumentation
aws-samples/aws-lambda-adapter→awslabs/aws-lambda-web-adapter)Testing
All unit and integration tests pass. No new tests needed — this is a removal of deprecated code and documentation additions.
Note
The version bump (
1.0.0-rc1→1.0.0) and corresponding Dockerfile/example/doc updates are intentionally excluded and will be done in a separate PR.