Make randomness generation deterministic under BORINGSSL_UNSAFE_FUZZER_MODE#3136
Open
torben-hansen wants to merge 2 commits intoaws:mainfrom
Open
Make randomness generation deterministic under BORINGSSL_UNSAFE_FUZZER_MODE#3136torben-hansen wants to merge 2 commits intoaws:mainfrom
torben-hansen wants to merge 2 commits intoaws:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3136 +/- ##
==========================================
- Coverage 77.95% 77.93% -0.03%
==========================================
Files 689 689
Lines 122506 122525 +19
Branches 17095 17095
==========================================
- Hits 95505 95495 -10
- Misses 26102 26131 +29
Partials 899 899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
When
BORINGSSL_UNSAFE_DETERMINISTIC_MODEis defined (e.g. via-DFUZZ=1), the entropy source layer now routes seed and extra entropy requests throughCRYPTO_sysrand, which is already deterministic in this mode (ChaCha20 with counter-based nonce). This bypasses jitter and hardware entropy sources, ensuring fully deterministic randomness generation end-to-end to support fuzzing.Testing:
Added small assertion test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.