Rename __AWS_LC_ENSURE to AWS_LC_ENSURE to avoid reserved identifier#3137
Open
torben-hansen wants to merge 1 commit intoaws:mainfrom
Open
Rename __AWS_LC_ENSURE to AWS_LC_ENSURE to avoid reserved identifier#3137torben-hansen wants to merge 1 commit intoaws:mainfrom
torben-hansen wants to merge 1 commit intoaws:mainfrom
Conversation
Identifiers starting with double underscores are reserved by the C and C++ standards (C11 §7.1.3, C++17 §5.10) for the implementation. Rename the internal macro to use the existing AWS_LC_ prefix convention.
torben-hansen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
torben-hansen
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
=======================================
Coverage 77.95% 77.96%
=======================================
Files 689 689
Lines 122506 122505 -1
Branches 17095 17094 -1
=======================================
+ Hits 95505 95512 +7
+ Misses 26102 26094 -8
Partials 899 899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
__AWS_LC_ENSUREmacro uses a double-underscore prefix, which is reserved by the C and C++ standards: Identifiers starting with double underscores are reserved by the C and C++ standards (C11 §7.1.3, C++17 §5.10) for the implementation. Using reserved identifiers is technically undefined behavior.No functional change. The macro is internal-only and not exposed in any public header.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.