[integ-tests] Add DCV authentication coverage for dotted and long AD usernames#7453
Open
hanwen-cluster wants to merge 1 commit into
Open
[integ-tests] Add DCV authentication coverage for dotted and long AD usernames#7453hanwen-cluster wants to merge 1 commit into
hanwen-cluster wants to merge 1 commit into
Conversation
…usernames
Extend the AD integration test to exercise the DCV external authenticator with usernames that contain a "." and that exceed 8 characters, covering the cookbook fix for username validation and UID-based session ownership.
Changes:
- Enable DCV in the AD cluster configs.
- Create additional AD users ("pcluster.user", "pcluster.long.user") that contain a dot and exceed 8 characters.
- After the user workloads, start a DCV session as each of these users and assert the authenticator validates the session for that username.
Refactoring:
- Add tests/common/dcv_common.py with shared helpers to start a DCV session and assert the authenticator accepts it for a given username.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Extend the AD integration test to exercise the DCV external authenticator with usernames that contain a "." and that exceed 8 characters, covering the cookbook fix for username validation and UID-based session ownership.
Changes:
Refactoring:
Tests
The following tests have been passed
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.