Use x-amz-retry-after for suggested delay#6914
Merged
dagnir merged 2 commits intofeature/master/2026-new-retriesfrom Apr 29, 2026
Merged
Use x-amz-retry-after for suggested delay#6914dagnir merged 2 commits intofeature/master/2026-new-retriesfrom
dagnir merged 2 commits intofeature/master/2026-new-retriesfrom
Conversation
dagnir
force-pushed
the
dongie/2026-new-retries/x-amz-retry-after
branch
2 times, most recently
from
97b0ed4 to
ecd324a
Compare
In retries 2.1, 'x-amz-retry-after' must be parsed from the last response and if present, should be used as the suggested delay (i.e. suggested backoff) when attempting another retry. This changes makes updates to RetryableStage and AsyncRetryableStage to parse the header and pass it to the RetryStrategy. As part of this change, we also need to plumb whether retries 2.1 is enabled from the SDK client.
dagnir
force-pushed
the
dongie/2026-new-retries/x-amz-retry-after
branch
from
ecd324a to
575b7ce
Compare
|
joviegas
approved these changes
Apr 29, 2026
dagnir
merged commit 4de251e
into
feature/master/2026-new-retries
21 of 31 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In retries 2.1, 'x-amz-retry-after' must be parsed from the last response and if present, should be used as the suggested delay (i.e. suggested backoff) when attempting another retry.
This changes makes updates to RetryableStage and AsyncRetryableStage to parse the header and pass it to the RetryStrategy. As part of this change, we also need to plumb whether retries 2.1 is enabled from the SDK client.
Modifications
x-amz-retry-afterin sync/async retry stages and use insuggestedDelay()when callingrefreshRetryToken().Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License