Skip to content

Retries fixes#6920

Merged
dagnir merged 1 commit intofeature/master/2026-new-retriesfrom
dongie/2026-new-retries/maxattempts-limit-exceeded-fixes
Apr 29, 2026
Merged

Retries fixes#6920
dagnir merged 1 commit intofeature/master/2026-new-retriesfrom
dongie/2026-new-retries/maxattempts-limit-exceeded-fixes

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented Apr 29, 2026

Motivation and Context

Fix some issues with the original retries implementation and gate behind 2.1 flag.

Modifications

This commit fixes two issues with the original retries implementation:

  • Honor the 'max_retries' property in the profile file if present
  • Treat 'LimitExceededException' as a throttling exception

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner April 29, 2026 18:33
@dagnir dagnir force-pushed the dongie/2026-new-retries/maxattempts-limit-exceeded-fixes branch from 4bb1a6c to fd4f0fc Compare April 29, 2026 19:23
This commit fixes two issues with the original retries implementation:

 - Honor the 'max_retries' property in the profile file if present
 - Treat 'LimitExceededException' as a throttling exception
@dagnir dagnir force-pushed the dongie/2026-new-retries/maxattempts-limit-exceeded-fixes branch from fd4f0fc to 995ee21 Compare April 29, 2026 19:58
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
34 Security Hotspots
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dagnir dagnir merged commit 3eb8f81 into feature/master/2026-new-retries Apr 29, 2026
29 of 32 checks passed
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants