Skip to content

Retry on IDPCommunicationError#6923

Merged
dagnir merged 2 commits intofeature/master/2026-new-retriesfrom
dongie/2026-new-retries/sts-retry-fix
Apr 30, 2026
Merged

Retry on IDPCommunicationError#6923
dagnir merged 2 commits intofeature/master/2026-new-retriesfrom
dongie/2026-new-retries/sts-retry-fix

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented Apr 30, 2026

Motivation and Context

Retries 2.1 fixes.

Modifications

This commit adds a fix to STS to retry on IDPCommunicationError. This is implemented as a customization for the retry strategy lookup for the client. This is gated behind the AWS_NEW_RETRIES_2026 flag.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the dongie/2026-new-retries/sts-retry-fix branch from 1ae408b to 9cca517 Compare April 30, 2026 17:22
@dagnir dagnir changed the title wip Retry on IDPCommunicationError Apr 30, 2026
@dagnir dagnir marked this pull request as ready for review April 30, 2026 17:24
@dagnir dagnir requested a review from a team as a code owner April 30, 2026 17:24
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
34 Security Hotspots
C Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dagnir dagnir mentioned this pull request Apr 30, 2026
12 tasks
Comment thread services/sts/pom.xml
<groupId>software.amazon.awssdk</groupId>
<artifactId>retries</artifactId>
<version>${awsjavasdk.version}</version>
</dependency>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should we add <scope>test</scope> here as well? Looks like its only used in test

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

This commit adds a fix to STS to retry on IDPCommunicationError. This is
implemented as a customization for the retry strategy lookup for the
client. This is gated behind the AWS_NEW_RETRIES_2026 flag.
@dagnir dagnir force-pushed the dongie/2026-new-retries/sts-retry-fix branch from 2ff50cc to 8b4864d Compare April 30, 2026 20:52
@dagnir dagnir merged commit 5db9f3d into feature/master/2026-new-retries Apr 30, 2026
1 check passed
@dagnir dagnir deleted the dongie/2026-new-retries/sts-retry-fix branch April 30, 2026 21:07
@github-actions
Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants