Skip to content

Fix NPE in AsyncRetryableStage#6936

Merged
aws-sdk-java-automation merged 1 commit intomasterfrom
dongie/fix-npe-last-response
May 5, 2026
Merged

Fix NPE in AsyncRetryableStage#6936
aws-sdk-java-automation merged 1 commit intomasterfrom
dongie/fix-npe-last-response

Conversation

@dagnir
Copy link
Copy Markdown
Contributor

@dagnir dagnir commented May 5, 2026

Motivation and Context

When retrying and checking for the 'x-amz-retry-after' or 'retry-after' header on the response, ensure that the response is not null first.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

When retrying and checking for the 'x-amz-retry-after' or 'retry-after'
header on the response, ensure that the response is not null first.
@dagnir dagnir requested a review from a team as a code owner May 5, 2026 17:07
@dagnir dagnir enabled auto-merge May 5, 2026 17:14
@dagnir dagnir added this pull request to the merge queue May 5, 2026
@aws-sdk-java-automation aws-sdk-java-automation removed this pull request from the merge queue due to a manual request May 5, 2026
@aws-sdk-java-automation aws-sdk-java-automation merged commit 5deef3c into master May 5, 2026
13 of 14 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 5, 2026
@dagnir
Copy link
Copy Markdown
Contributor Author

dagnir commented May 5, 2026

Correction on description/commit: this only relates to x-amz-retry-after since this is specific to the async retry stage, which never looked at retry-after. Furthermore, this code path is only hit if using retries 2.1 (off by default).

@dagnir dagnir deleted the dongie/fix-npe-last-response branch May 5, 2026 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants