Skip to content

feat(codegen): generate empty SdkWarmUpProvider and META-INF/services registration per service#7085

Merged
joviegas merged 2 commits into
feature/master/crac_auto_priming_supportfrom
joviegas/crac_codegen_service_modules
Jun 30, 2026
Merged

feat(codegen): generate empty SdkWarmUpProvider and META-INF/services registration per service#7085
joviegas merged 2 commits into
feature/master/crac_auto_priming_supportfrom
joviegas/crac_codegen_service_modules

Conversation

@joviegas

@joviegas joviegas commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

This change makes codegen emit a provider plus its ServiceLoader registration in every service module. The warmUp() body is empty in this PR; the synthetic priming call is added in a follow-up PR.

Modifications

  • WarmUpProviderSpec: generates <Service>WarmUpProvider in <service>.internal.crac, implementing SdkWarmUpProvider with an empty warmUp().
  • WarmUpProviderRegistrationTask: writes the provider's class name into META-INF/services/software.amazon.awssdk.core.crac.SdkWarmUpProvider. Creates the file once, appends per service, skips duplicates.
  • WarmUpProviderTasks: emits both outputs, wired into AwsGeneratorTasks so every service runs it.
  • Metadata.getFullCracInternalPackageName() and GeneratorPathProvider.getWarmUpProviderDirectory(): resolve the package and output directory.

Testing

  • Added Junits in codegen
  • Will add test in codegen-generated-classes-test after Part B that is implementation of actual wampUp api for each services is completed.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

License

  • I confirm that this pull request can be released under the Apache 2 license

joviegas added 2 commits June 26, 2026 14:29
…g specs implementation where we donot genrate javadocs for generated interfaces
@joviegas joviegas requested a review from a team as a code owner June 26, 2026 21:54
@joviegas joviegas merged commit e727287 into feature/master/crac_auto_priming_support Jun 30, 2026
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants