Open
Conversation
…or Go applications, and while the .spec file in the base directory works fine. and is arguably simpler, the files in fedora/ are in the format that Fedora requires. The go2rpm tooling generates a second tarball that contains all of the Go module dependencies, and builds them locally. not downloaded over the network. so that the package can build in Fedoras air-gapped buildserver. It also does not use the provided Makefile, instead invoking go build directly with Fedoras preferred optflags. Signed-off-by: Tom spot Callaway <spotaws@amazon.com>
| sha256sum = "d18f6323b71b0b768bb5e9616e36da390fbd39369a81807cca352de4e4e6aa0b" | ||
| expression = "MIT AND (MIT AND Apache-2.0)" | ||
| [[licensing.licenses]] | ||
| path = "cmd/credentials-fetcher/LICENSE.txt" |
There was a problem hiding this comment.
Would be better to add a LICENSE.txt file to the project root path, so you don't have to add it as source and workaround with Go Vendor Tools.
Contributor
There was a problem hiding this comment.
yes, @spotaws had also brought this up as well, we will address this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fedora has specific packaging standards for Go applications, and while the .spec file in the base directory works fine. and is arguably simpler, the files in fedora/ are in the format that Fedora requires. The go2rpm tooling generates a second tarball that contains all of the Go module dependencies, and builds them locally. not downloaded over the network. so that the package can build in Fedoras air-gapped buildserver. It also does not use the provided Makefile, instead invoking go build directly with Fedoras preferred optflags.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.