Fixed usages of expectedBucketOwner which were unguarded against empty strings#201
Merged
Cole-Greer merged 1 commit intodevelopfrom Mar 25, 2026
Merged
Fixed usages of expectedBucketOwner which were unguarded against empty strings#201Cole-Greer merged 1 commit intodevelopfrom
Cole-Greer merged 1 commit intodevelopfrom
Conversation
xiazcy
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Fixes a bug from #196 in which some usages of
expectedBucketOwnerin S3 requests were guarded against empty strings, while others (notably in the ML handlers) remained unguarded.This PR simply adds blank string guards to the remaining usages of
expectedBucketOwner.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.