Fix/wait respects sagemaker session 5765#5774
Open
aviruthen wants to merge 3 commits intoaws:masterfrom
Open
Conversation
|
|
||
| if wait: | ||
| training_job.wait(logs=logs) | ||
| trainer_wait( |
Member
There was a problem hiding this comment.
Could you help me understand the reasoning for moving away from the autogenerated waiter here? I noticed we introduced a dedicated waiter for ModelCustomization tailored to those specific flows — I'm curious whether the intent is to also adopt custom waiters across all high-level abstractions going forward?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Bug fix for the first issue mentioned in GitHub issue 5765! Ports waiting logic from PySDK V2 to V3 and allows users to optionally wait for Processing Jobs or Training Jobs without running into the aforementioned NoCredentialsError
Description of changes:
Did local integration testing to verify job waiting was working as expected, added unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.