updated deeplearning.template#21
updated deeplearning.template#21ajayvohra2005 wants to merge 6 commits intoawslabs:masterfrom ajayvohra2005:master
Conversation
|
@ajayvohra2005 Can you provide some details about this PR? |
add support for EbsOptimized flag on EC2 instances
|
Hi @ajayvohra2005, as we discussed, do you have an ETA to make those features in a customized template and keep the default template as a generic one? Let me know if you need any help. Also the latest commit in master has been updated to DLAMI v21.0. |
| "AllowedValues" : [ "AmazonLinux", "Ubuntu" ], | ||
| "ConstraintDescription" : "Amazon Supported Image Type" | ||
| }, | ||
| "AMIOverride" : { |
There was a problem hiding this comment.
This is a really great feature that allow users not limited to current version of dlami. Thanks!
| "Default": "/dev/sda1", | ||
| "Description" : "Ebs device name", | ||
| "Type" : "String", | ||
| "AllowedValues": [ "/dev/sda1" ] |
There was a problem hiding this comment.
If there is only one allowed value here, should it be default?
| "Default" : "1" | ||
| }, | ||
| "InstanceType" : { | ||
| "Description" : "The EC2 instance type for workers.For GPUs choose g3.xx, p2.xx or p3.xx.", |
There was a problem hiding this comment.
Please use origin line g3.xx, p2.xx or p3.xx. here
| "g3.16xlarge", | ||
| "g3.8xlarge", | ||
| "g3.4xlarge", | ||
| "p3dn.24xlarge", |
There was a problem hiding this comment.
g2 are no longer supported by DLAMI so they should be removed.
"p3dn.24xlarge",
"g3.16xlarge",
"g3.8xlarge",
"g3.4xlarge",
Please using these values here.
| "Type": "String", | ||
| "MinLength": "1", | ||
| "Default": "myEFSvolume" | ||
| "Default": "efs" |
There was a problem hiding this comment.
It's better to keep as myEFSvolume as current README file and auto script commands are running based on this string. Is there a reason it should be changed to efs?
| "Default": "true", | ||
| "AllowedValues": [ "false", "true"] | ||
| }, | ||
| "ActivateCondaEnv" : { |
There was a problem hiding this comment.
This will benefit people who use conda environment, but it's better to keep this as an optional, given that we allow using customized AMI so people might also use base AMI or other AMI which does not install Conda then this will fail.
|
@ajayvohra2005 Thanks for creating this PR for adding so many awesome features!
|
3 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.